On Tue, Nov 22, 2022 at 7:23 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > > 07. proto.c - logicalrep_write_stream_abort() > > We may able to add assertions for abort_lsn and abort_time, like xid and > subxid. >
If you see logicalrep_write_stream_commit(), we have an assertion for xid but not for LSN and other parameters. I think the current coding in the patch is consistent with that. > > 08. guc_tables.c - ConfigureNamesInt > > ``` > &max_sync_workers_per_subscription, > + 2, 0, MAX_PARALLEL_WORKER_LIMIT, > + NULL, NULL, NULL > + }, > ``` > > The upper limit for max_sync_workers_per_subscription seems to be wrong, it > should > be used for max_parallel_apply_workers_per_subscription. > Right, I don't know why this needs to be changed in the first place. -- With Regards, Amit Kapila.
