On Wed, 30 Nov 2022 at 03:56, Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Tue, Nov 29, 2022 at 12:02:44PM +0000, Simon Riggs wrote: > > The last important point for me is tests, in src/test/modules > > probably. It might be possible to reuse the final state of other > > modules' tests to test cleanup, or at least integrate a custodian test > > into each module. > > Of course. I found some existing tests for the test_decoding plugin that > appear to reliably generate the files we want the custodian to clean up, so > I added them there.
Thanks for adding the tests; I can see they run clean. The only minor thing I would personally add is a note in each piece of code to explain where the tests are for each one and/or something in the main custodian file that says tests exist within src/test/module. Otherwise, ready for committer. -- Simon Riggs http://www.EnterpriseDB.com/
