> On 30 Nov 2022, at 08:04, Peter Eisentraut > <peter.eisentr...@enterprisedb.com> wrote: > > For historical reasons, pg_dump refers to large objects as "BLOBs". This term > is not used anywhere else in PostgreSQL, and it also means something > different in the SQL standard and other SQL systems. > > This patch renames internal functinos, code comments, documentation, etc. to > use the "large object" or "LO" terminology instead. There is no > functionality change, so the archive format still uses the name "BLOB" for > the archive entry. Additional long command-line options are added with the > new naming.
+1 on doing this. No pointy bits stood out when reading, just a few small comments: The commit message contains a typo: functinos * called for both BLOB and TABLE data; it is the responsibility of - * the format to manage each kind of data using StartBlob/StartData. + * the format to manage each kind of data using StartLO/StartData. Should BLOB be changed to BLOBS here (and in similar comments) to make it clearer that it refers to the archive entry and the concept of a binary large object in general? Theres an additional mention in src/test/modules/test_pg_dump/t/001_base.pl: # Tests which are considered 'full' dumps by pg_dump, but there. # are flags used to exclude specific items (ACLs, blobs, etc). -- Daniel Gustafsson https://vmware.com/