On 02.12.22 15:07, Andrew Dunstan wrote:
On 2022-12-01 Th 05:02, Peter Eisentraut wrote:
Keeping the SQL commands that initdb runs in string arrays before
feeding them to PG_CMD_PUTS() seems unnecessarily verbose and
inflexible. In some cases, the array only has one member. In other
cases, one might want to use PG_CMD_PRINTF() instead, to parametrize a
command, but that would require breaking up the loop or using
workarounds like replace_token(). This patch unwinds all that; it's
much simpler that way.
Looks reasonable. (Most of this dates back to 2003/2004, the very early
days of initdb.c.)
committed
