Thomas Munro <thomas.mu...@gmail.com> writes: > Do you think this is better?
I'm not at all on board with adding runtime overhead to save maintaining the nkeys fields. Getting rid of the useless trailing zeroes in the key[] arrays is clearly a win, though. I'm kind of neutral on using "[N] = " as a substitute for ordering the entries correctly. While that does remove one failure mode, it seems like it adds another (ie failure to provide an entry at all would be masked). regards, tom lane