On Tue, Jan 03, 2023 at 02:20:38PM +0300, Pavel Borisov wrote: > Hi, Alexander! > > On Tue, 3 Jan 2023 at 13:48, Alexander Korotkov <aekorot...@gmail.com> wrote: > > > > On Tue, Jan 3, 2023 at 11:51 AM Pavel Borisov <pashkin.e...@gmail.com> > > wrote: > > > On Tue, 3 Jan 2023 at 09:29, Alexander Korotkov <aekorot...@gmail.com> > > > wrote: > > > > > > > > On Mon, Jan 2, 2023 at 6:42 PM Justin Pryzby <pry...@telsasoft.com> > > > > wrote: > > > > > On Mon, Jan 02, 2023 at 06:14:48PM +0300, Alexander Korotkov wrote: > > > > > > I'm going to push this if no objections. > > > > > > > > > > I also suggest that meson.build should not copy regress_args. > > > > > > > > Good point, thanks. > > > Nice, thanks! > > > Isn't there the same reason to remove regress_args from meson.build in > > > oat's test and possibly from other modules with runningcheck=false? > > > > This makes sense to me too. I don't see anything specific in oat's > > regression test that requires setting regress_args. > Yes, it seems so. > Regress args in oat's Makefile are added as a response to a buildfarm > issues by 7c51b7f7cc08. They seem unneeded to be copied into > meson.build with runningcheck=false. I may mistake but it seems to me > that removing regress_args from meson.build with runningcheck=false is > just to make it neat, not for functionality. So I consider fixing it > in pg_db_role_setting, oat, or both of them optional.
Right - my suggestion is to "uncopy" them from pg_db_role_setting, where they serve no purpose, since they shouldn't have been copied originally. On Tue, Jan 03, 2023 at 09:29:00AM +0300, Alexander Korotkov wrote: > On Mon, Jan 2, 2023 at 6:42 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Mon, Jan 02, 2023 at 06:14:48PM +0300, Alexander Korotkov wrote: > > > I'm going to push this if no objections. > > > > I also suggest that meson.build should not copy regress_args. > > Good point, thanks. I should've mentioned that the same things should be removed from Makefile, too... -- Justin
