I wrote: > Michael Paquier <mich...@paquier.xyz> writes: >> FYI, here is the failure: >> [21:23:10.814] In file included from pg_prng.c:27: >> [21:23:10.814] ../../src/include/utils/float.h:46:16: error: ‘struct >> Node’ declared inside parameter list will not be visible outside of >> this definition or declaration [-Werror] >> [21:23:10.814] 46 | struct Node *escontext);
> Hmm ... this looks an awful lot like it is the fault of ccff2d20e > not of the random_normal patch; that is, we probably need a > "struct Node" stub declaration in float.h. [ ... some head-scratching later ... ] No, we don't per our normal headerscheck rules, which are that headers such as utils/float.h need to be compilable after including just postgres.h. The "struct Node" stub declaration in elog.h will be visible, making the declaration of float8in_internal kosher. So the problem in this patch is that it's trying to include utils/float.h in a src/common file, where we have not included postgres.h. Question is, why did you do that? I see nothing in pg_prng_double_normal() that looks like it should require that header. If it did, it'd be questionable whether it's okay to be in src/common. regards, tom lane