On Fri, Dec 23, 2022 at 4:55 PM Robert Haas <robertmh...@gmail.com> wrote:
> On Thu, Dec 22, 2022 at 9:14 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> 
> wrote:
> > The contents looks good to me other than that problem, and I agree to
> > backpatch it.
>
> Cool. Thanks for the review.
>
> > Why did you choose to use two dots for ellipses in some command
> > <literal>s rather than three?  I know I've made that choice too on
> > occassion, but there aren't many such cases and maybe we should put a
> > stop to it (or a period) before it spreads too much.
>
> Honestly, I wasn't aware that we had some other convention for it.

Committed and back-patched 0001 with fixes for the issues that you pointed out.

Here's a trivial rebase of the rest of the patch set.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment: v3-0001-Refactor-permissions-checking-for-role-grants.patch
Description: Binary data

Attachment: v3-0004-Add-new-GUC-createrole_self_grant.patch
Description: Binary data

Attachment: v3-0002-Pass-down-current-user-ID-to-AddRoleMems-and-DelR.patch
Description: Binary data

Attachment: v3-0003-Restrict-the-privileges-of-CREATEROLE-users.patch
Description: Binary data

Reply via email to