Hi Jose, thank you for review and sorry for so long delay to answer. On Wed, Dec 14, 2022 at 4:19 AM Jose Arthur Benetasso Villanova <jose.art...@gmail.com> wrote: > > > On Sun, 27 Nov 2022, Andrey Borodin wrote: > > > On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodi...@gmail.com> > > wrote: > >> > > I was wrong. GIN check does similar gin_refind_parent() to lock pages > > in bottom-up manner and truly verify downlink-child_page invariant. > > Does this mean that we need the adjustment in docs? It seems to me that gin_index_parent_check() docs are correct.
> > > Here's v17. The only difference is that I added progress reporting to > > GiST verification. > > I still did not implement heapallindexed for GIN. Existence of pending > > lists makes this just too difficult for a weekend coding project :( > > > > Thank you! > > > > Best regards, Andrey Borodin. > > > > I'm a bit lost here. I tried your patch again and indeed the > heapallindexed inside gin_check_parent_keys_consistency has a TODO > comment, but it's unclear to me if you are going to implement it or if the > patch "needs review". Right now it's "Waiting on Author". > Please find the attached new version. In this patchset heapallindexed flag is removed from GIN checks. Thank you! Best regards, Andrey Borodin.
v18-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch
Description: Binary data
v18-0002-Add-gist_index_parent_check-function-to-verify-G.patch
Description: Binary data
v18-0001-Refactor-amcheck-to-extract-common-locking-routi.patch
Description: Binary data
