Hi! In overall, I think we move in the right direction. But we could make code better, should we?
+ /* Capture exit code for SHELL_EXIT_CODE */ + close_exit_code = pclose(fd); + if (close_exit_code == -1) + { + pg_log_error("%s: %m", cmd); + error = true; + } + if (WIFEXITED(close_exit_code)) + exit_code=WEXITSTATUS(close_exit_code); + else if(WIFSIGNALED(close_exit_code)) + exit_code=WTERMSIG(close_exit_code); + else if(WIFSTOPPED(close_exit_code)) + exit_code=WSTOPSIG(close_exit_code); + if (exit_code) + error = true; I think, it's better to add spaces around middle if block. It will be easy to read. Also, consider, adding spaces around assignment in this block. + /* + snprintf(exit_code_buf, sizeof(exit_code_buf), "%d", WEXITSTATUS(exit_code)); + */ Probably, this is not needed. > 1. pg_regress now creates an environment variable called PG_OS_TARGET Maybe, we can use env "OS"? I do not know much about Windows, but I think this is kind of standard environment variable there. -- Best regards, Maxim Orlov.