On Tue, Jan 17, 2023 at 11:56:42AM -0800, Andres Freund wrote:
> > $(CF_PGP_TESTS) is missing from contrib/pgcrypto/meson.build
>
> Assume that's the false positive?
Yes
> > I also tried but failed to write something to warn if "meson test" was
> > run with a list of tests but without tmp_install. Help wanted.
>
> That doesn't even catch the worst case - when there's tmp_install, but it's
> too old.
I don't understand what you mean by "too old" ?
> > I propose to put something like this into "SanityCheck".
>
> Perhaps we instead could add it as a separate "meson-only" test? Then it'd
> fail on developer's machines, instead of later in CI. We could pass the test
> information from the 'tests' array, or it could look at the metadata in
> meson-info/intro-tests.json
I guess you mean that it should be *able* to fail on developer machines
*in addition* to cirrusci.
But, a meson-only test might not be so helpful, as it assumes that the
developer is using meson, in which case the problem would tend not to
have occured in the first place.
BTW I also noticed that:
meson.build:meson_binpath_r = run_command(python, 'src/tools/find_meson',
check: true)
meson.build-
meson.build-if meson_binpath_r.returncode() != 0 or meson_binpath_r.stdout() ==
''
meson.build- error('huh, could not run find_meson.\nerrcode: @0@\nstdout:
@1@\nstderr: @2@'.format(
The return code will never be nonzero since check==true, right ?
--
Justin
