On Fri, Jan 27, 2023 at 3:45 PM vignesh C <vignes...@gmail.com> wrote: > > On Mon, 23 Jan 2023 at 10:52, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > IIRC, this is done to prevent concurrent drops of origin drop say by > > exposed API pg_replication_origin_drop(). See the discussion in [1] > > related to it. If we want we can optimize it so that we can acquire > > the lock on the specific origin as mentioned in comments > > replorigin_drop_by_name() but it was not clear that this operation > > would be frequent enough. > > Here is an attached patch to lock the replication origin record using > LockSharedObject instead of locking pg_replication_origin relation in > ExclusiveLock mode. Now tablesync worker will wait only if the > tablesync worker is trying to drop the same replication origin which > has already been dropped by the apply worker, the other tablesync > workers will be able to successfully drop the replication origin > without any wait. >
There is a code in the function replorigin_drop_guts() that uses the functionality introduced by replorigin_exists(). Can we reuse this function for the same? Also, it would be good if you can share the numbers for different runs of "src/test/subscription/t/002_types.pl" before and after the patch. -- With Regards, Amit Kapila.
