On Tue, Jan 31, 2023 at 3:57 PM wangw.f...@fujitsu.com <wangw.f...@fujitsu.com> wrote: > > On Mon, Jan 23, 2023 21:00 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > > Hi, > > > > Thanks for your review. > > Attached updated versions of the patches. > > Thanks for updating the patch set. > > > > 5. New member "created_slot" in structure LogicalRepWorker > > > + /* > > > + * Indicates if the sync worker created a replication slot or it > > > reuses an > > > + * existing one created by another worker. > > > + */ > > > + bool created_slot; > > >
> Yes, I think it makes sense. Thanks for the detailed explanation. > I think I misunderstood the second half of the comment. I previously thought > it > meant that it was also true when reusing an existing slot. > I agree with Wang-san that the comment is confusing, I too misunderstood it initially during my first run of the code. Maybe it can be improved. 'Indicates if the sync worker created a replication slot for itself; set to false if sync worker reuses an existing one created by another worker' thanks Shveta
