On Tue, Jan 31, 2023 at 6:20 PM Peter Geoghegan <p...@bowt.ie> wrote: > Actually the really wide output comes from COMMIT records. After I run > the regression tests, and execute some of my own custom pg_walinspect > queries, I see that some individual COMMIT records have a > length(description) of over 10,000 bytes/characters. There is even one > particular COMMIT record whose length(description) is about 46,000 > bytes/characters. So *ludicrously* verbose GetRmgr() strings are not > uncommon today. The worst case (or even particularly bad cases) won't > be made any worse by this patch, because there are obviously limits on > the width of the arrays that it outputs details descriptions of, that > don't apply to these COMMIT records.
If we're dumping a lot of details out of each WAL record, we might want to switch to a multi-line format of some kind. No one enjoys a 460-character wide line, let alone 46000. -- Robert Haas EDB: http://www.enterprisedb.com
