On Fri, Feb 3, 2023 at 8:02 AM Peter Smith <smithpb2...@gmail.com> wrote: > > I think there is some misunderstanding. I was not suggesting removing > the condition -- only that I thought it could be written without the > > 0 as: > > if (IsSet(supported_opts, SUBOPT_MIN_APPLY_DELAY) && > opts->min_apply_delay && opts->streaming == LOGICALREP_STREAM_PARALLEL) > ereport(ERROR, >
Yeah, we can probably write that way but in the error message we are already using > 0, so the current style used by patch seems good to me. Also, I think using the way you are suggesting is more apt for booleans. -- With Regards, Amit Kapila.
