Hi, Horiguchi-san
Thanks for your review ! On Tuesday, February 7, 2023 1:43 PM From: Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > At Mon, 6 Feb 2023 13:10:01 +0000, "Takamichi Osumi (Fujitsu)" > <osumi.takami...@fujitsu.com> wrote in > subscriptioncmds.c > > + if (opts.streaming == > LOGICALREP_STREAM_PARALLEL && > + !IsSet(opts.specified_opts, > SUBOPT_MIN_APPLY_DELAY) && > +sub->minapplydelay > 0) > .. > + if (opts.min_apply_delay > 0 && > + !IsSet(opts.specified_opts, > SUBOPT_STREAMING) && sub->stream == > +LOGICALREP_STREAM_PARALLEL) > > Don't we wrap the lines? Yes, those lines should have looked nicer. Updated. Kindly have a look at the latest patch v31 in [1]. There are also other some changes in the patch. [1] - https://www.postgresql.org/message-id/TYCPR01MB8373BA483A6D2C924C600968EDDB9%40TYCPR01MB8373.jpnprd01.prod.outlook.com Best Regards, Takamichi Osumi