Hi,

On 2023-02-09 09:57:42 -0500, Tom Lane wrote:
> Peter Eisentraut <peter.eisentr...@enterprisedb.com> writes:
> > On 08.02.23 23:18, Tom Lane wrote:
> >> I pushed the discussed documentation improvements, and changed the
> >> behavior of "ninja docs" to only build the HTML docs.
>
> > I don't like this change.  Now the default set of docs is different
> > between the make builds and the meson builds.  And people will be less
> > likely to make sure the man pages still build.
>
> What?  The default behavior of "make" has been to build only the
> html docs for many years.  And I've never ever seen a case where
> the html docs build and the man pages don't.

I think this misunderstanding is again due to the confusion between the 'all'
target in doc/src/sgml and the default target, just like earlier in the thread
/ why I ended up with the prior set of targets under 'docs'.

  # Make "html" the default target, since that is what most people tend
  # to want to use.
  html:
  ...
  all: html man


Given the repeated confusion from that, among fairly senior hackers, perhaps
we ought to at least put those lines next to each other? It's certainly not
obvious as-is.



> > What's wrong with just typing "ninja html"?
>
> Don't really care how the command is spelled, but there needs to
> be a convenient way to get that behavior.

Perhaps we should have doc-html, doc-man, doc-all or such?

The shell autocompletions for ninja work pretty well for me, a prefix like
that would make it easier to discover such "sub"-targets.


I'm was pondering adding a 'help' target that shows important targets.

Greetings,

Andres Freund


Reply via email to