On Tue, Feb 21, 2023 at 12:40 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: > > On 2023-Feb-20, Amit Langote wrote: > >> One more thing we could try is come up with a postgres_fdw test case, > >> because it uses the RelOptInfo.userid value for remote-costs-based > >> path size estimation. But adding a test case to contrib module's > >> suite test a core planner change might seem strange, ;-). > > > Maybe. Perhaps adding it in a separate file there is okay? > > There is plenty of stuff in contrib module tests that is really > there to test core-code behavior. (You could indeed argue that > *all* of contrib is there for that purpose.) If it's not > convenient to test something without an extension, just do it > and don't sweat about that.
OK. Attached adds a test case to postgres_fdw's suite. You can see that it fails without a316a3bc. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
v1-0001-postgres_fdw-test-userid-propagation-to-rels-unde.patch
Description: Binary data
