> On Thu, Feb 16, 2023 at 10:24:13AM +0530, Dilip Kumar wrote: > > Yes, there is no reason to pass this as false, seems like this is > > passed false by mistake. And your patch fixes the issue.
On Thu, Feb 16, 2023 at 02:26:55PM +0900, Michael Paquier wrote: > So, if I am understanding this stuff right, this issue can create data > corruption once a DDL updates any pages of pg_class stored in a > template database that gets copied by this routine. In this case, the > patch sent makes sure that any page copied will get written once a > checkpoint kicks in. Thank you for comment and patch. I think that the patch for dbcommand.c is fixed. So I apply to my environment. > I have not given much attention to this area, but I am a bit > suspicious that enforcing the default as WAL_LOG was a good idea for > 15~, TBH. We are usually much more conservative when it comes to > such choices, switching to the new behavior after a few years would > have been wiser.. I think so too. I was surprised that new strategy is default. Regards Ryo Matsumura
