From 614ac11bcdba08ae8ce2844b72312a818379aced Mon Sep 17 00:00:00 2001 From: Samay Sharma Date: Mon, 13 Feb 2023 16:23:52 -0800 Subject: [PATCH v8 3/5] Remove Anti-Features section from Installation from source docs Currently, several meson setup options are listed in anti-features. However, they are similar to most other options in the postgres features list as they are 'auto' features themselves. Also, other options are likely better suited to the developer options section. This commit, therefore, moves the options listed in the anti-features section into other sections and removes that section. For consistency, this reorganization has been done on the make section of the docs as well. --- doc/src/sgml/installation.sgml | 166 ++++++++++++++------------------- 1 file changed, 70 insertions(+), 96 deletions(-) diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml index 657330d368..9c7ee91cb9 100644 --- a/doc/src/sgml/installation.sgml +++ b/doc/src/sgml/installation.sgml @@ -1214,23 +1214,6 @@ build-postgresql: - - - - - - Anti-Features - - - The options described in this section allow disabling - certain PostgreSQL features that are built - by default, but which might need to be turned off if the required - software or system features are not available. Using these options is - not recommended unless really necessary. - - - - @@ -1270,47 +1253,6 @@ build-postgresql: - - - - - Allow the build to succeed even if PostgreSQL - has no CPU spinlock support for the platform. The lack of - spinlock support will result in very poor performance; therefore, - this option should only be used if the build aborts and - informs you that the platform lacks spinlock support. If this - option is required to build PostgreSQL on - your platform, please report the problem to the - PostgreSQL developers. - - - - - - - - - Disable use of CPU atomic operations. This option does nothing on - platforms that lack such operations. On platforms that do have - them, this will result in poor performance. This option is only - useful for debugging or making performance comparisons. - - - - - - - - - Disable the thread-safety of client libraries. This prevents - concurrent threads in libpq and - ECPG programs from safely controlling - their private connection handles. Use this only on platforms - with deficient threading support. - - - - @@ -1702,6 +1644,47 @@ build-postgresql: + + + + + Allow the build to succeed even if PostgreSQL + has no CPU spinlock support for the platform. The lack of + spinlock support will result in very poor performance; therefore, + this option should only be used if the build aborts and + informs you that the platform lacks spinlock support. If this + option is required to build PostgreSQL on + your platform, please report the problem to the + PostgreSQL developers. + + + + + + + + + Disable use of CPU atomic operations. This option does nothing on + platforms that lack such operations. On platforms that do have + them, this will result in poor performance. This option is only + useful for debugging or making performance comparisons. + + + + + + + + + Disable the thread-safety of client libraries. This prevents + concurrent threads in libpq and + ECPG programs from safely controlling + their private connection handles. Use this only on platforms + with deficient threading support. + + + + @@ -2661,13 +2644,6 @@ ninja install - - - - - Anti-Features - - @@ -2707,36 +2683,6 @@ ninja install - - - - - - This option is set to true by default; setting it to false will - allow the build to succeed even if PostgreSQL - has no CPU spinlock support for the platform. The lack of - spinlock support will result in very poor performance; therefore, - this option should only be changed if the build aborts and - informs you that the platform lacks spinlock support. If setting this - option to false is required to build PostgreSQL on - your platform, please report the problem to the - PostgreSQL developers. - - - - - - - - - This option is set to true by default; setting it to false will - disable use of CPU atomic operations. The option does nothing on - platforms that lack such operations. On platforms that do have - them, disabling atomics will result in poor performance. Changing - this option is only useful for debugging or making performance comparisons. - - - @@ -3158,8 +3104,36 @@ ninja install + + + + + This option is set to true by default; setting it to false will + allow the build to succeed even if PostgreSQL + has no CPU spinlock support for the platform. The lack of + spinlock support will result in very poor performance; therefore, + this option should only be changed if the build aborts and + informs you that the platform lacks spinlock support. If setting this + option to false is required to build PostgreSQL on + your platform, please report the problem to the + PostgreSQL developers. + + + - + + + + + This option is set to true by default; setting it to false will + disable use of CPU atomic operations. The option does nothing on + platforms that lack such operations. On platforms that do have + them, disabling atomics will result in poor performance. Changing + this option is only useful for debugging or making performance comparisons. + + + + -- 2.38.1