On Sat, Feb 25, 2023 at 01:39:21PM +0900, Michael Paquier wrote: > pg_input_error_message() does not strike me as a good function name, > though, because it now returns much more than an error message. > Hence, couldn't something like pg_input_error() be better, because > more generic?
I personally think the existing name is fine. It returns the error message, which includes the primary, detail, and hint messages. Also, I'm not sure that pg_input_error() is descriptive enough. That being said, I'm happy to run the sed command to change the name to whatever folks think is best. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
