Nathan Bossart <[email protected]> writes: > On Wed, Mar 01, 2023 at 05:59:45PM -0500, Tom Lane wrote: >> + /* attidx is zero-based, attrnum is the normal attribute number */ >> + int attrnum = attidx + FirstLowInvalidHeapAttributeNumber;
> nitpick: Shouldn't this be an AttrNumber?
I stuck with the existing type choices for those variables,
but I don't mind changing to AttrNumber here.
regards, tom lane
