Justin Pryzby <pry...@telsasoft.com> writes: > The idea would be for: > 1) TOTAL to show the number of direct and indirect leaf partitions; > 2) update progress while building direct or indirect indexes; > 3) ATTACHing intermediate partitioned tables to increment by 0; > 4) ATTACHing a direct child should continue to increment by 1, > since that common case already works as expected and shouldn't be > changed.
OK. > The only change from the current patch is (3). (1) still calls > count_leaf_partitions(), but only once. I'd prefer that to rearranging > the progress reporting to set the TOTAL in ProcessUtilitySlow(). I don't agree with that. find_all_inheritors is fairly expensive and it seems completely silly to do it twice just to avoid adding a parameter to DefineIndex. regards, tom lane