On 13.03.23 22:11, Andres Freund wrote:
It adds branches, and it makes tupledescs wider. In tight spots, such as
printtup, that can hurt, even if the branches aren't ever entered.
In fact, I do see a noticable, but not huge, regression:
I tried to reproduce your measurements, but I don't have the CPU
affinity tools like that on macOS, so the differences were lost in the
noise. (The absolute numbers looked very similar to yours.)
I can reproduce a regression if I keep adding more columns to
pg_attribute, like 8 OID columns does start to show.
I investigated whether I could move some columns to the
"variable-length" part outside the tuple descriptor, but that would
require major surgery in heap.c and tablecmds.c (MergeAttributes() ...
shudder), and also elsewhere, where you currently only have a tuple
descriptor for looking up stuff.
How do we proceed here? A lot of user-facing table management stuff
like compression, statistics, collation, dropped columns, and probably
future features like column reordering or periods, have to be
represented in pg_attribute somehow, at least in the current
architecture. Do we hope that hardware keeps up with the pace at which
we add new features? Do we need to decouple tuple descriptors from
pg_attribute altogether? How do we decide what goes into the tuple
descriptor and what does not? I'm interested in addressing this,
because obviously we do want the ability to add more features in the
future, but I don't know what the direction should be.
