On Fri, Mar 17, 2023 11:29 PM Önder Kalacı <onderkal...@gmail.com> wrote: > > Thanks for sharing. Fixed > > > This time I was able to run all the tests with all the patches applied. > > Again, the generated column fix also has some minor differences > per version. So, overall we have 6 patches with very minor > differences :)
Thanks for updating the patches. It seems you forgot to attach the patches of dropped columns for HEAD and pg15, I think they are the same as v2. On HEAD, we can re-use clusters in other test cases, which can save some time. (see fccaf259f22f4a) In the patches for pg12 and pg11, I am not sure why not add the test at end of the file 100_bugs.pl. I think it would be better to be consistent with other versions. The attached patches modify these two points. Besides, I made some minor changes, ran pgindent and pgperltidy. These are patches for dropped columns, because I think this would be submitted first, and we can discuss the fix for generated columns later. Regards, Shi Yu
v4-pg12-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
Description: v4-pg12-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
v4-pg13-pg14-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
Description: v4-pg13-pg14-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
v4-pg15-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
Description: v4-pg15-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
v4-HEAD-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FULL.patch
Description: v4-HEAD-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FULL.patch
v4-pg11-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
Description: v4-pg11-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch
