Hi,
Commit dee663f7 made WAIT_EVENT_SLRU_FLUSH_SYNC redundant, so here's a
patch to remove it.
In case it's useful again, here's how I noticed:
for X in ` grep WAIT_EVENT_ src/include/utils/wait_event.h |
sed '/^#/d;s/,//;s/ = .*//' `
do
if ! ( git grep $X |
grep -v src/include/utils/wait_event.h |
grep -v src/backend/utils/activity/wait_event.c |
grep $X > /dev/null )
then
echo "$X is not used"
fi
done
From 5bd5d5448b1fbd01833069af72bf12d19eef42dd Mon Sep 17 00:00:00 2001
From: Thomas Munro <[email protected]>
Date: Thu, 23 Mar 2023 14:36:27 +1300
Subject: [PATCH] Remove orphaned wait event.
Commit dee663f7 made WAIT_EVENT_SLRU_FLUSH_SYNC redundant.
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 7ab4424bf1..45259efd0f 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1468,11 +1468,6 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<entry><literal>ReplicationSlotWrite</literal></entry>
<entry>Waiting for a write to a replication slot control file.</entry>
</row>
- <row>
- <entry><literal>SLRUFlushSync</literal></entry>
- <entry>Waiting for SLRU data to reach durable storage during a checkpoint
- or database shutdown.</entry>
- </row>
<row>
<entry><literal>SLRURead</literal></entry>
<entry>Waiting for a read of an SLRU page.</entry>
diff --git a/src/backend/utils/activity/wait_event.c b/src/backend/utils/activity/wait_event.c
index 7940d64639..23a85345b7 100644
--- a/src/backend/utils/activity/wait_event.c
+++ b/src/backend/utils/activity/wait_event.c
@@ -672,9 +672,6 @@ pgstat_get_wait_io(WaitEventIO w)
case WAIT_EVENT_REPLICATION_SLOT_WRITE:
event_name = "ReplicationSlotWrite";
break;
- case WAIT_EVENT_SLRU_FLUSH_SYNC:
- event_name = "SLRUFlushSync";
- break;
case WAIT_EVENT_SLRU_READ:
event_name = "SLRURead";
break;
diff --git a/src/include/utils/wait_event.h b/src/include/utils/wait_event.h
index 518d3b0a1f..14b7ac5cf6 100644
--- a/src/include/utils/wait_event.h
+++ b/src/include/utils/wait_event.h
@@ -207,7 +207,6 @@ typedef enum
WAIT_EVENT_REPLICATION_SLOT_RESTORE_SYNC,
WAIT_EVENT_REPLICATION_SLOT_SYNC,
WAIT_EVENT_REPLICATION_SLOT_WRITE,
- WAIT_EVENT_SLRU_FLUSH_SYNC,
WAIT_EVENT_SLRU_READ,
WAIT_EVENT_SLRU_SYNC,
WAIT_EVENT_SLRU_WRITE,
--
2.39.2
