On Thu, May 17, 2018 at 4:20 AM, Paul Guo <paul...@gmail.com> wrote: > Thanks. I tentatively submitted a patch (See the attachment).
You probably want to add this to the next Commitfest. > By the way, current pg_upgrade test script depends on the left data on test > database, but it seems that > a lot of tables are dropped in those test SQL files so this affects the > pg_upgrade test coverage much. > Maybe this needs to be addressed in the future. (Maybe when anyone checks in > test cases pg_upgrade > needs to be considered also?) There's been a deliberate attempt to leave a representative selection of tables not dropped for this exact reason, but it's definitely possible that interesting cases have been missed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company