On Tue, Mar 28, 2023 at 02:03:49PM -0400, Kirk Wolak wrote: > On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra <tomas.von...@enterprisedb.com> > wrote: > > On 3/27/23 19:28, Justin Pryzby wrote: > > > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote: > > >> On 3/16/23 05:50, Justin Pryzby wrote: > > >>> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote: > > >>>> On Wed, Mar 8, 2023 at 10:59 AM Jacob Champion > > >>>> <jchamp...@timescale.com> wrote: > > >>>>> I did some smoke testing against zstd's GitHub release on Windows. To > > ... > > OK. I don't have access to a Windows machine so I can't test that. Is it > > possible to disable the zstd threading, until we figure this out? > > Thomas since I appear to be one of the few windows users (I use both), can I > help? > I can test pg_dump... for you, easy to do. I do about 5-10 pg_dumps a day > on windows while developing.
It'd be great if you'd exercise this and other changes to pg_dump/restore. Tomas just pushed a bugfix, so be sure to "git pull" before testing, or else you might rediscover the bug. If you have a zstd library with thread support, you could test with -Z zstd:workers=3. But I think threads aren't enabled in the common libzstd packages. Jacob figured out how to compile libzstd easily using "meson wraps" - but I don't know the details. -- Justin