On Fri, May 18, 2018 at 10:53 PM, John Naylor <jcnay...@gmail.com> wrote: > On 5/17/18, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> Hi John, >> >> This failed for my patch testing robot on Windows, with this message[1]: > ... >> I see that you changed src/backend/catalog/Makefile to pass the new -I >> switch to genbki.pl. I think for Windows you might need to add it to >> the line in src/tools/msvc/Solution.pm that invokes genbki.pl via >> system()? > > Yes, you're quite right. Thanks for the report. I've attached an > updated v2 patchset, with some additional revisions:
Looks good on Windows[1] but now it's broken on Linux[2] (also reproducible on my macOS laptop): make[2]: *** No rule to make target `../../../src/include/pg_proc.dat', needed by `fmgr-stamp'. Stop. [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.75 [2] https://travis-ci.org/postgresql-cfbot/postgresql/builds/380898356 -- Thomas Munro http://www.enterprisedb.com
