Greetings, * Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: > At 2018-05-18 20:27:57 -0400, sfr...@snowman.net wrote: > > > > I don't agree with the general notion that we can't have a function > > which handles the complicated bits about the kind of error because > > someone grep'ing the source for PANIC might have to do an additional > > lookup. > > Or we could just name the function promote_eio_to_PANIC.
Ugh, I'm not thrilled with that either. > (I understood the objection to be about how 'grep PANIC' wouldn't find > these lines at all, not that there would be an additional lookup.) ... and my point was that 'grep PANIC' would, almost certainly, find the function promote_eio_to_panic(), and someone could trivially look up all the callers of that function then. Thanks! Stephen
signature.asc
Description: PGP signature
