On Thu, Apr 13, 2023 at 12:16 PM Michael Paquier <mich...@paquier.xyz> wrote: > The logic in hba.c that scans all the HBA and ident lines to any > regexps can be simplified a lot. Most of this code is new in 16~, so > I think that it is worth cleaning up this stuff now rather than wait > for 17 to open for business. Still, this is optional, and I don't > mind waiting for 17 if the regexp/palloc business proves to be an > issue during beta.
Up to the RMT of course, but it sounds a bit like (1) you potentially had an open item already until last week (new code in 16 that could leak regexes), and (2) I missed this when looking for manual memory management code that could be nuked, probably because it's hiding behind a few layers of functions call, but there are clearly comments that are now wrong. So there are two different ways for a commitfest lawyer to argue this should be tidied up for 16.
