On Mon, Apr 24, 2023 at 7:26 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > While looking at the worker.c, I realized that we have the following > code in handle_streamed_transaction(): > > default: > Assert(false); > return false; / silence compiler warning / > > I think it's better to do elog(ERROR) instead of Assert() as it ends > up returning false in non-assertion builds, which might cause a > problem. And it's more consistent with other codes in worker.c. Please > find an attached patch. >
I haven't tested it but otherwise, the changes look good to me. -- With Regards, Amit Kapila.