> On 11 May 2023, at 07:41, Peter Smith <smithpb2...@gmail.com> wrote:
> While reviewing another patch for the file info.c, I noticed some
> misplaced colon (':') in the verbose logs for print_rel_infos().
That spelling was introduced in c2e9b2f28818 which was the initial import of
pg_upgrade into contrib/ for the 9.0 release (at that time the function was
relarr_print() which via a few other names was renamed to print_rel_infos() in
0a5f1199319).
It's not entirely clear to me if the current spelling is a mistake or
intentional, but I do agree that your version is an improvement.
To be consistent with other log output in pg_upgrade we should probably also
wrap the relname and reltblspace in quotes as \"%s.%s\" and \"%s\" (and the
Database in print_db_infos()).
--
Daniel Gustafsson
