On Sat, May 27, 2023 at 09:34:37PM -0400, Bruce Momjian wrote:
> > > This is controlled by auto_explain.log_parameter_max_length, and by
> > > default query parameters will be logged with no length
> > > restriction. SHOULD THIS BE MORE CLEARLY IDENTIFIED AS CONTROLLING THE
> > > EXECUTION OF PREPARED STATEMENTS?
> > 
> > This is wrong, the logging applies to all query parameters, not just for
> > prepared statements (and has nothing to do with controlling the
> > execution thereof).  That was just the only way to test it when it was
> > written, because psql's \bind command exist yet then.
> 
> I see your point.  How is this?
> 
>       Allow auto_explain to log query parameters used by parameterized
>       statements (Dagfinn Ilmari Mannsåker)
> 
>       This affects queries using server-side PRAPARE/EXECUTE
>       and client-side parse/bind.  Logging is controlled by
>       auto_explain.log_parameter_max_length;  by default query
>       parameters will be logged with no length restriction.

Done, attached patch applied.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.
diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index 816286575f..32678074d2 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -2838,12 +2838,12 @@ Author: Michael Paquier <mich...@paquier.xyz>
 
 <listitem>
 <para>
-Allow auto_explain to log query parameters used in executing prepared statements (Dagfinn Ilmari Mannsåker)
+Allow auto_explain to log values passed to parameterized statements (Dagfinn Ilmari Mannsåker)
 </para>
 
 <para>
-This is controlled by auto_explain.log_parameter_max_length, and by default query parameters will be logged with no length restriction.
-SHOULD THIS BE MORE CLEARLY IDENTIFIED AS CONTROLLING THE EXECUTION OF PREPARED STATEMENTS?
+This affects queries using server-side PRAPARE/EXECUTE and client-side parse/bind.  Logging is controlled by auto_explain.log_parameter_max_length;  by default query parameters will
+be logged with no length restriction.
 </para>
 </listitem>
 

Reply via email to