David Steele <da...@pgmasters.net> writes:
> Thank you, this was very helpful. I am able to get the expected result
> now with:
> /* We only care about tables/views and can ignore subqueries, etc. */
> if (!(rte->rtekind == RTE_RELATION ||
> (rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid))))
> continue;
Right, that matches places like add_rtes_to_flat_rtable().
> One thing, though, rte->relkind is not set for views, so I still need to
> call get_rel_relkind(rte->relid). Not a big deal, but do you think it
> would make sense to set rte->relkind for views?
If you see "rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid)",
it's dead certain that relid refers to a view, so you could just wire
in that knowledge.
regards, tom lane
