On Tue, Jun 27, 2023 at 03:44:04PM +0900, Kyotaro Horiguchi wrote: > +# - Timeline number in hex format. > > Arn't we reffering to it as "Timeline ID"? (I remember there was a > discussion about redefining the "timeline ID" to use non-orderable > IDs. That is, making it non-numbers.)
Using ID is fine by me. > The file name was "LSNh-LSNl.spcOid.dbOid.relNumber.blk_forkname", but > the comment in the TAP script read as: > > -# XXXXXXXX-XXXXXXXX.DBOID.TLOID.NODEOID.dd_fork with the components being: > > which looks wrong. I'm not sure it is a business of this patch, though.. This part is getting changed here anyway, so improving it is fine by me with the terms you are suggesting for these two 4-byte values in this comment. -- Michael
signature.asc
Description: PGP signature
