Richard Guo <guofengli...@gmail.com> writes: > BTW, it seems that extra->sjinfo would always have a valid value here. > So maybe we do not need to check if it is not NULL explicitly?
Right, I was being conservative but this module expects that to always be provided. Pushed with that and defenses added to try_mergejoin_path and try_hashjoin_path. It looks like the various try_partial_xxx_path functions already reject cases that could be problematic. (They will not accept inner parameterization that would lead to the result being parameterized differently from the outer path. By induction, that should be fine.) regards, tom lane