Hi Nathan, On Fri, Jun 30, 2023 at 2:39 PM Nathan Bossart <nathandboss...@gmail.com> wrote:
> > In v4, I've introduced a new BGW_LIBLEN macro and set it to the default > value of MAXPGPATH (1024). This way, the value can live in bgworker.h like > the other BGW_* macros do. Plus, this should make the assertion that > checks for backward compatibility unnecessary. Since bgw_library_name is > essentially a path, I can see the argument that we should just set > BGW_LIBLEN to MAXPGPATH directly. I'm curious what folks think about this. > Thank you for revising the patch. While this is relatively minor, I think it should be set to MAXPGPATH directly to clarify their relationship. -- Y.
