On Fri, Jul 7, 2023 at 10:55 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi, Here are my review comments for patch v2. > > ====== > 1. doc/src/sgml/logical-replication.sgml > > Candidate indexes must be btree, non-partial, and have at least one > column reference to the published table column at the leftmost column > (i.e. cannot consist of only expressions). > > ~ > > There is only one column which can be the leftmost one, so the wording > "At least one ... at the leftmost" seemed a bit strange to me. > Personally, I would phrase it something like below: > > SUGGESTION #1 > Candidate indexes must be btree, non-partial, and the leftmost index > column must reference a published table column (i.e. the index cannot > consist of only expressions).
I prefer the first suggestion. I've attached the updated patch. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v3-0001-Doc-clarify-the-conditions-of-usable-indexes-for-.patch
Description: Binary data
