On Tue, Jul 11, 2023 at 2:28 AM Peter Eisentraut <pe...@eisentraut.org> wrote: > This looks sensible to me. > > If we ever need mbstowcs_l() etc. outside of pg_locale.c, then the > proper way would be to make a mbstowcs_l.c file in src/port/. > > But I like your approach for now because it moves us more firmly into > the direction of having it contained in pg_locale.c, instead of having > some knowledge global and some local.
Thanks. Pushed. That leaves only one further cleanup opportunity from discussion this thread, for future work: a TRUST_STRXFRM-ectomy.