On Fri, Jul 21, 2023 at 4:43 AM John Morris <john.mor...@crunchydata.com> wrote: > > Based on your feedback, I’ve updated the patch with additional comments. > > Explain the two cases when writing to the control file, and > a bit more emphasis on unloggedLSNs not being valid after a crash.
Given that the callers already have to deal with the unloggedLSN being reset after a crash, meaning, they can't expect an always increasing value from unloggedLSN, I think converting it to an atomic variable seems a reasonable change. The other advantage we get here is the freeing up shared memory space for spinlock ulsn_lck. The attached v2 patch LGTM and marked the CF entry RfC - https://commitfest.postgresql.org/43/4330/. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
