On Wed, Jul 26, 2023 at 10:10 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some comments for patch v22-0001. > > ====== > 1. General -- naming conventions > > There is quite a lot of inconsistency with variable/parameter naming > styles in this patch. I understand in most cases the names are copied > unchanged from the original functions. Still, since this is a big > refactor anyway, it can also be a good opportunity to clean up those > inconsistencies instead of just propagating them to different places. >
I am not against improving consistency in the naming of existing variables but I feel it would be better to do as a separate patch along with improving the consistency function names. For new functions/variables, it would be good to follow a consistent style. -- With Regards, Amit Kapila.
