Hi Richard, On Mon, Jul 24, 2023 at 11:45 AM Richard Guo <guofengli...@gmail.com> wrote: > On Fri, Jul 21, 2023 at 8:51 PM Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: >> * In this bit I changed the last argument to NIL, which would be >> nitpicking, though. >> >> @@ -1038,7 +1038,7 @@ postgresGetForeignPaths(PlannerInfo *root, >> add_path(baserel, (Path *) path); >> >> /* Add paths with pathkeys */ >> - add_paths_with_pathkeys_for_rel(root, baserel, NULL); >> + add_paths_with_pathkeys_for_rel(root, baserel, NULL, NULL);
> This was my oversight. No. IIUC, I think that that would work well as-proposed, but I changed it as such, for readability. > So the two patches both look good to me now. Cool! I pushed the first patch after polishing it a little bit, so here is a rebased version of the second patch, in which I modified the ForeignPath and CustomPath cases in reparameterize_path_by_child() to reflect the new members fdw_restrictinfo and custom_restrictinfo, for safety, and tweaked a comment a bit. Thanks for looking! Best regards, Etsuro Fujita
0002-Allow-join-pushdown-even-if-pseudoconstant-quals-v3.patch
Description: Binary data
