On Wed, Aug 2, 2023 at 8:20 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Aug 1, 2023 at 12:11 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > > > On 2023-Aug-01, Peter Smith wrote: > > > > > PSA a small patch making those above-suggested changes. The 'make > > > check' and TAP subscription tests are all passing OK. > > > > I think the code ends up more readable with this style of changes, so > > +1. I do wonder if these calls should appear in a proc_exit callback or > > some such instead, though. > > > > But the call to > ApplyLauncherForgetWorkerStartTime()->logicalrep_launcher_attach_dshmem() > has some dynamic shared memory allocation/attach calls which I am not > sure is a good idea to do in proc_exit() callbacks. We may want to > evaluate whether moving the suggested checks to proc_exit or any other > callback is a better idea. What do you think? >
I have pushed the existing patch but feel free to pursue further improvements. -- With Regards, Amit Kapila.
