On Fri, Aug 11, 2023 at 3:30 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > No. I presume koel is using src/tools/pgindent/typedefs.list, > which has always been the "canonical" list but up to now we've > been lazy about maintaining it. Part of the new regime is that > typedefs.list should now be updated on-the-fly by patches that > add new typedefs.
My workflow up until now has avoiding making updates to typedefs.list in patches. I only update typedefs locally, for long enough to indent my code. The final patch doesn't retain any typedefs.list changes. > We should still compare against the buildfarm's list periodically; > but I imagine that the primary result of that will be to remove > no-longer-used typedefs from typedefs.list. I believe that I came up with my current workflow due to the difficulty of maintaining the typedef file itself. Random platform/binutils implementation details created a lot of noise, presumably because my setup wasn't exactly the same as Bruce's setup, in whatever way. For example, the order of certain lines would change, in a way that had nothing whatsoever to do with structs that my patch added. I guess that I can't do that anymore. Hopefully maintaining the typedefs.list file isn't as inconvenient as it once seemed to me to be. -- Peter Geoghegan
