On Tue, Aug 22, 2023 at 7:19 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for v23-0001 > > ====== > 1. GENERAL -- git apply > > The patch fails to apply cleanly. There are whitespace warnings. > > [postgres@CentOS7-x64 oss_postgres_misc]$ git apply > ../patches_misc/v23-0001-Always-persist-to-disk-logical-slots-during-a-sh.patch > ../patches_misc/v23-0001-Always-persist-to-disk-logical-slots-during-a-sh.patch:102: > trailing whitespace. > # SHUTDOWN_CHECKPOINT record. > warning: 1 line adds whitespace errors. > > ~~~ > > 2. GENERAL -- which patch is the real one and which is the copy? > > IMO this patch has become muddled. > > Amit recently created a new thread [1] "persist logical slots to disk during > shutdown checkpoint", which I thought was dedicated to the > discussion/implementation of this 0001 patch. >
Right, I feel it would be good to discuss 0001 on the new thread. Here, we can just include it for the sake of completeness and testing purposes. -- With Regards, Amit Kapila.
