On 13.09.23 16:36, Aleksander Alekseev wrote:
``` + // FIXME: why 2? if (set_oldest_commit_ts_xid < 2 && ```Should we rewrite this to < FrozenTransactionId ?
That's what I suspect, but we should confirm that.
``` +$mult = 32 * $blcksz * 4; # FIXME ``` Unless I'm missing something this $mult value is not used. Is it really needed here?
The FIXME is that I think a multiplier *should* be applied somehow. See also the FIXME in the documentation for the -c option.
