> On 13 Sep 2023, at 16:12, Peter Eisentraut <pe...@eisentraut.org> wrote:

> The alignment of this output looks a bit funny:
> 
> ...
> Checking for prepared transactions                            ok
> Checking for contrib/isn with bigint-passing mismatch         ok
> Checking for data type usage                                  checking all 
> databases
> ok
> Checking for presence of required libraries                   ok
> Checking database user is the install user                    ok
> ...

I was using the progress reporting to indicate that it hadn't stalled for slow
systems, but it's not probably not all that important really.  Removed such
that "ok" aligns.

> Also, you should put gettext_noop() calls into the .status = "Checking ..."
> assignments and arrange to call gettext() where they are used, to maintain
> the translatability.

Ah, yes of course. Fixed.

--
Daniel Gustafsson

Attachment: v9-0001-pg_upgrade-run-all-data-type-checks-per-connectio.patch
Description: Binary data

Reply via email to