Dear Bharath, > > You mentioned at line 118, but at that time logical replication system is > > not > created. > > The subscriber is created at line 163. > > Therefore WALs would not be consumed automatically. > > So, not calling pg_logical_slot_get_changes() on test_slot1 won't > consume the WAL?
Yes. This slot was created manually and no one activated it automatically. pg_logical_slot_get_changes() can consume WALs but never called. > > 2. > +++ b/src/bin/pg_upgrade/t/003_logical_replication_slots.pl > > How about a more descriptive and pointed name for the TAP test file, > something like 003_upgrade_logical_replication_slots.pl? Good suggestion. Renamed. > 3. Does this patch support upgrading of logical replication slots on a > streaming standby? If yes, isn't it a good idea to add one test for > upgrading standby with logical replication slots? IIUC pg_upgrade would not be used for physical standby. The standby would be upgrade by: * Recreating the database cluster, or * Executing rsync command. For more detail, please see the documentation. Best Regards, Hayato Kuroda FUJITSU LIMITED
