"Drouvot, Bertrand" <bertranddrouvot...@gmail.com> writes: > Hi hackers, > > Please find attached a tiny patch to $SUBJECT. > > It: > > - provides more consistency to the way we get files size in TAP tests > - seems more elegant that relying on a hardcoded result position
I approve of removing use of the list form of stat, it's a horrible API. If we weren't already using -s everywhere else, I would prefer File::stat, which makes stat (in scalar context) return an object with methods for the fields, so you'd do stat($file)->size. It's included in Perl core since 5.4, and we're already using it in several places for other fields (mode and ino at least). I see another use of stat array positions (for mtime) in src/tools/msvc/Solution.pm, but that's on the chopping block, so not much point in fixing. - ilmari
